namada icon indicating copy to clipboard operation
namada copied to clipboard

Ledger test case generator does not check for chainid

Open feliam opened this issue 1 year ago • 0 comments

https://github.com/anoma/namada/blob/e74fdc71aa2ea6f192c0151f492fb770e1c0cfcb/crates/sdk/src/signing.rs#L1127

The testcases for ledger apps generated with "to_ledger_vector" may not be checking for chain-id in the output. Ledger apps tested with these vector may end up not showing the chain_id and users may be trick to sign mainnet tx while interacting with testnets.

feliam avatar Jan 29 '25 05:01 feliam