namada icon indicating copy to clipboard operation
namada copied to clipboard

MASP shielded sync client phase 1

Open sug0 opened this issue 1 year ago • 1 comments

Describe your changes

Supersedes #3405, #3426 (rebase of the last one on the latest release)

Implements phase 1 of Issue #3385

  • When fetching notes, connections and related failures should not halt shielded sync. Instead, the process should be restarted
  • If fetching is interrupted, the data fetched should be persisted locally so that progress isn't lost
  • A trait for fetching behavior should be added to provide modularity

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

sug0 avatar Jul 10 '24 09:07 sug0

Codecov Report

Attention: Patch coverage is 75.08091% with 231 lines in your changes missing coverage. Please review.

Project coverage is 54.04%. Comparing base (8479d38) to head (6a18bc1). Report is 4 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/client/masp.rs 0.00% 118 Missing :warning:
crates/sdk/src/masp.rs 88.04% 79 Missing :warning:
crates/sdk/src/masp/test_utils.rs 84.74% 18 Missing :warning:
crates/sdk/src/masp/utils.rs 26.31% 14 Missing :warning:
crates/apps_lib/src/cli/client.rs 0.00% 1 Missing :warning:
crates/sdk/src/control_flow/mod.rs 90.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3498      +/-   ##
==========================================
+ Coverage   53.48%   54.04%   +0.56%     
==========================================
  Files         320      322       +2     
  Lines      110000   110866     +866     
==========================================
+ Hits        58832    59920    +1088     
+ Misses      51168    50946     -222     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 10 '24 09:07 codecov[bot]