namada icon indicating copy to clipboard operation
namada copied to clipboard

split up apps bin and lib crates

Open tzemanovic opened this issue 1 year ago • 1 comments

Describe your changes

relates to #2111

There are advantages in not mixing lib and bin code in a single crate so this PR is splitting these up. This PR adds a new crates/apps_lib with the library code split up from crates/apps

Indicate on which release or other PRs this topic is based on

draft

diff: https://github.com/anoma/namada/pull/3259/files/b0321a51246b6558450d670c07e9315275a76ab1..b132a3a30da1b60d61d1ed981408b363cb06244b

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

tzemanovic avatar May 16 '24 13:05 tzemanovic

Codecov Report

Attention: Patch coverage is 48.64682% with 1518 lines in your changes are missing coverage. Please review.

Project coverage is 53.98%. Comparing base (4ed6229) to head (b132a3a).

Files Patch % Lines
crates/sdk/src/signing.rs 0.00% 742 Missing :warning:
crates/sdk/src/masp.rs 0.00% 96 Missing :warning:
crates/namada/src/ledger/protocol/mod.rs 60.79% 69 Missing :warning:
crates/apps_lib/src/client/utils.rs 0.00% 68 Missing :warning:
...s/apps_lib/src/node/ledger/shell/finalize_block.rs 87.02% 62 Missing :warning:
crates/apps_lib/src/bench_utils.rs 0.00% 52 Missing :warning:
crates/sdk/src/rpc.rs 0.00% 46 Missing :warning:
crates/events/src/extend.rs 0.00% 33 Missing :warning:
crates/namada/src/vm/host_env.rs 82.14% 30 Missing :warning:
crates/apps_lib/src/config/genesis/chain.rs 12.90% 27 Missing :warning:
... and 49 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
- Coverage   60.24%   53.98%   -6.27%     
==========================================
  Files         303      313      +10     
  Lines       93191   105311   +12120     
==========================================
+ Hits        56145    56854     +709     
- Misses      37046    48457   +11411     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 16 '24 17:05 codecov[bot]