namada icon indicating copy to clipboard operation
namada copied to clipboard

Draft

Open tzemanovic opened this issue 1 year ago • 1 comments

WARNING: ☠️ do not merge this branch into your development branches and do not rely on it being stable. ☠️

Contains:

  • #2975
  • #2817
  • #3209
  • #3215
  • #3196
  • #3216
  • #3228
  • #3195
  • #3214 - evil 253676e731c95a0166df61a5467a6e3b7ec96ad9
  • #3220 - evil 4cafd2c626f27b0c16290686717b972bdbf3fcb1
  • #3226
  • #3241
  • #3257
  • #3218
  • #3258
  • #3233
  • #3103 - evil 30bb889ae96429ca891244052e01758e16b155d4 1dfa217f823d3959a56b9108f2fc15a3a76d7514
  • #3217 - evil b0321a51246b6558450d670c07e9315275a76ab1
  • #3264

Queue (unordered):

  • #3273
  • #3259 - 2nd last
  • #3254 - update toolchain to 1.78 as the last PR

To finish and needed:

  • non-merklized data needs to be part of app hash

To author and needed:

  • Ensure that all state which determines transaction execution results is in fact committed to in the app hash

To finish and optional for next release:

  • https://github.com/anoma/namada/pull/3006
  • #2597
  • #3234

Totally optional:

  • #2831
  • #2561 (maybe?)

tzemanovic avatar May 09 '24 13:05 tzemanovic

Codecov Report

Attention: Patch coverage is 69.42801% with 310 lines in your changes are missing coverage. Please review.

Project coverage is 60.25%. Comparing base (4ed6229) to head (6747f02).

:exclamation: Current head 6747f02 differs from pull request most recent head dc6c44e

Please upload reports for the commit dc6c44e to get more accurate results.

Files Patch % Lines
crates/tx/src/data/wrapper.rs 54.25% 43 Missing :warning:
crates/apps/src/lib/config/genesis/chain.rs 12.90% 27 Missing :warning:
crates/namada/src/vm/host_env.rs 82.01% 25 Missing :warning:
crates/apps/src/lib/node/ledger/mod.rs 0.00% 24 Missing :warning:
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 60.52% 15 Missing :warning:
crates/sdk/src/masp.rs 0.00% 13 Missing :warning:
crates/namada/src/ledger/vp_host_fns.rs 63.33% 11 Missing :warning:
crates/tx/src/types.rs 68.57% 11 Missing :warning:
crates/apps/src/lib/node/ledger/tendermint_node.rs 0.00% 10 Missing :warning:
crates/apps/src/lib/node/ledger/shell/mod.rs 70.96% 9 Missing :warning:
... and 32 more
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3213    +/-   ##
========================================
  Coverage   60.24%   60.25%            
========================================
  Files         303      302     -1     
  Lines       93191    93535   +344     
========================================
+ Hits        56145    56361   +216     
- Misses      37046    37174   +128     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 13:05 codecov[bot]