namada icon indicating copy to clipboard operation
namada copied to clipboard

Make the internals of ValueSum private

Open batconjurer opened this issue 9 months ago • 3 comments

Describe your changes

Make the internals of ValueSum (in the masp crate) private so we know that invariants of representation are maintained

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

batconjurer avatar May 08 '24 08:05 batconjurer

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.24%. Comparing base (4ed6229) to head (12b2c2d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3195      +/-   ##
==========================================
- Coverage   60.24%   60.24%   -0.01%     
==========================================
  Files         303      303              
  Lines       93191    93191              
==========================================
- Hits        56145    56144       -1     
- Misses      37046    37047       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 09:05 codecov[bot]

@batconjurer Is this PR rdy for draft?

brentstone avatar May 10 '24 19:05 brentstone

@batconjurer Is this PR rdy for draft?

Yes it is

batconjurer avatar May 13 '24 08:05 batconjurer