namada icon indicating copy to clipboard operation
namada copied to clipboard

Add a validator alias field to validator metadata

Open McDaan opened this issue 11 months ago • 6 comments

Describe your changes

Closes #2910

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

McDaan avatar Mar 18 '24 00:03 McDaan

this looks nice! a couple of things are left to be done:

  • regenerate the localnet files in genesis/localnet
  • re-run make fmt

Thanks for your contribution!

Fraccaman avatar Mar 20 '24 21:03 Fraccaman

this looks nice! a couple of things are left to be done:

  • regenerate the localnet files in genesis/localnet
  • re-run make fmt

Thanks for your contribution!

@Fraccaman Done!

I've also created a PR to fix the command used to generate localnet files, since one of the flag values has a wrong path. https://github.com/anoma/namada/pull/3044

McDaan avatar Apr 10 '24 10:04 McDaan

Codecov Report

Attention: Patch coverage is 7.93651% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 59.37%. Comparing base (9d4de02) to head (294519c). Report is 12 commits behind head on main.

Files Patch % Lines
crates/proof_of_stake/src/storage.rs 8.00% 23 Missing :warning:
crates/proof_of_stake/src/storage_key.rs 0.00% 6 Missing :warning:
crates/sdk/src/args.rs 0.00% 6 Missing :warning:
crates/light_sdk/src/transaction/pos.rs 0.00% 4 Missing :warning:
crates/proof_of_stake/src/lib.rs 0.00% 4 Missing :warning:
crates/sdk/src/tx.rs 0.00% 4 Missing :warning:
crates/tx_prelude/src/proof_of_stake.rs 0.00% 4 Missing :warning:
crates/sdk/src/lib.rs 0.00% 3 Missing :warning:
crates/apps/src/lib/config/genesis/transactions.rs 33.33% 2 Missing :warning:
crates/sdk/src/queries/vp/pos.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
- Coverage   59.40%   59.37%   -0.04%     
==========================================
  Files         298      298              
  Lines       92326    92389      +63     
==========================================
+ Hits        54849    54853       +4     
- Misses      37477    37536      +59     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 10 '24 10:04 codecov[bot]

@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself.

brentstone avatar Apr 15 '24 16:04 brentstone

@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself.

@brentstone I'm trying to figure out how to do it correctly, but I don't want to mess up anything - so, yes, I'd be fine if you do so instead in order to avoid conflicts. Thanks :)

McDaan avatar Apr 15 '24 20:04 McDaan

@brentstone Done. I just gave you write access just in case I've made any mistake.

McDaan avatar Apr 16 '24 02:04 McDaan