namada
namada copied to clipboard
Add a validator alias field to validator metadata
Describe your changes
Closes #2910
Indicate on which release or other PRs this topic is based on
v0.34.0
Checklist before merging to draft
- [x] I have added a changelog
- [x] Git history is in acceptable state
this looks nice! a couple of things are left to be done:
- regenerate the localnet files in
genesis/localnet
- re-run
make fmt
Thanks for your contribution!
this looks nice! a couple of things are left to be done:
- regenerate the localnet files in
genesis/localnet
- re-run
make fmt
Thanks for your contribution!
@Fraccaman Done!
I've also created a PR to fix the command used to generate localnet files, since one of the flag values has a wrong path. https://github.com/anoma/namada/pull/3044
Codecov Report
Attention: Patch coverage is 7.93651%
with 58 lines
in your changes are missing coverage. Please review.
Project coverage is 59.37%. Comparing base (
9d4de02
) to head (294519c
). Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 59.40% 59.37% -0.04%
==========================================
Files 298 298
Lines 92326 92389 +63
==========================================
+ Hits 54849 54853 +4
- Misses 37477 37536 +59
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself.
@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself.
@brentstone I'm trying to figure out how to do it correctly, but I don't want to mess up anything - so, yes, I'd be fine if you do so instead in order to avoid conflicts. Thanks :)
@brentstone Done. I just gave you write access just in case I've made any mistake.