namada icon indicating copy to clipboard operation
namada copied to clipboard

Allows merkle roots to be recalculated and validated on bootup

Open batconjurer opened this issue 11 months ago • 8 comments

Describe your changes

Closes #3052.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

batconjurer avatar Feb 29 '24 13:02 batconjurer

Codecov Report

Attention: Patch coverage is 81.60920% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 59.42%. Comparing base (97ec5b4) to head (9feb44b). Report is 4 commits behind head on main.

Files Patch % Lines
crates/merkle_tree/src/lib.rs 80.48% 16 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2778      +/-   ##
==========================================
+ Coverage   59.39%   59.42%   +0.02%     
==========================================
  Files         298      298              
  Lines       92771    92858      +87     
==========================================
+ Hits        55104    55179      +75     
- Misses      37667    37679      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 29 '24 13:02 codecov[bot]

let's rm the cli arg and always validate

Sorry for not getting to this sooner. Fixing now.

batconjurer avatar Mar 08 '24 08:03 batconjurer

What's the status of this? Still relevant? @batconjurer

brentstone avatar Apr 10 '24 04:04 brentstone

What's the status of this? Still relevant? @batconjurer

Very much. I though that this was already merged actually

batconjurer avatar Apr 10 '24 08:04 batconjurer

this will conflict with #2926

Fraccaman avatar Apr 10 '24 17:04 Fraccaman

this will conflict with #2926

In what way? Such that it is not compatible anymore or no?

brentstone avatar Apr 10 '24 17:04 brentstone

we have a new branch in the merkle root, so this PR needs to be updated

Fraccaman avatar Apr 10 '24 18:04 Fraccaman

@brentstone This has been updated and should be ready to go.

batconjurer avatar Apr 16 '24 09:04 batconjurer