defopt icon indicating copy to clipboard operation
defopt copied to clipboard

Move defopt to package

Open macdems opened this issue 3 years ago • 5 comments

As the module grows, I think this is not elegant to put separate modules starting with _, but it should be combined in a package.

macdems avatar Dec 18 '21 20:12 macdems

Actually, I see that napoleon upstream just merged https://github.com/sphinx-contrib/napoleon/pull/36, fixing the 3.6 issue. Let's try to make them release that first, in which case we can go back to having napoleon as a dependency (which is my preferred approach).

anntzer avatar Dec 20 '21 19:12 anntzer

Ok, however still it would be much neater not to create an independent module _defopt_version, but collect it into a package.

macdems avatar Dec 21 '21 15:12 macdems

That part I'll probably completely get rid of and replace by https://github.com/pypa/setuptools_scm#retrieving-package-version-at-runtime.

anntzer avatar Dec 21 '21 16:12 anntzer

That part I'll probably completely get rid of and replace by https://github.com/pypa/setuptools_scm#retrieving-package-version-at-runtime.

Good idea!

macdems avatar Dec 21 '21 18:12 macdems

Done. I think the best thing you could do now is to prod the sphinxcontrib.napoleon maintainer for a new release :-)

anntzer avatar Dec 21 '21 18:12 anntzer

Let's just keep things as they are for now. Things work fine in practice (even though the dependency on sphinxcontrib.napoleon is somewhat inelegant), let's not overengineer them; we can always reconsider if there are actual breakages.

anntzer avatar Jun 18 '23 12:06 anntzer