Results 637 comments of Antony Lee

Certainly that would work too, my point was just that I wrote this a couple of weeks ago and only vaguely remember what was the rationale for the exact design...

You typoe'd my name, but fortunately I was looking at the tracker for other reasons and noticed this :) > This doesn't seem as useful as I thought, since it...

I think they should be (that's the intent of manylinux).

It depends what python extension gets loaded first. If it's pycairo (including if pygobject imports pycairo before importing its own extension module) then the RPATH cairo is loaded and then...

Nah, I'll let you handle the unfun work of actually making things work :) Your version is copied here :) ``` #!/bin/bash # Written by Antony Lee (@anntzer). set -e...

From a quick try I think ```patch diff --git i/src/pydocstyle/checker.py w/src/pydocstyle/checker.py index 41e3f35..2ec3e9d 100644 --- i/src/pydocstyle/checker.py +++ w/src/pydocstyle/checker.py @@ -332,10 +332,12 @@ class ConventionChecker: """ if docstring: indent = self._get_docstring_indent(definition,...

Actually, I think putting `__version__` in `__all__` is a pretty bad idea: someone who does `from foo import *` (say, in the `bar`) module will now also set `bar.__version__` (as...

As discussed in https://github.com/PyCQA/pyflakes/issues/387#issuecomment-435857561 adding them to `__all__` is not a good idea (you almost certainly don't want them imported if doing a star-import).

I agree, but that's what `__all__` is fundamentally about...