pyclustering icon indicating copy to clipboard operation
pyclustering copied to clipboard

ROCK implementation error

Open JosephChataignon opened this issue 3 years ago • 0 comments

There is an error in the implementation of ROCK algorithm. In the original paper describing the algorithm, the authors stress the fact that they use the number of links (defined as common neighbours) between clusters, rather than the number of neighbours, when they chose which clusters should be merged. They say one can obtain a matrix of links by multiplying the adjacency matrix by itself. In the current implementation, the goodness measure uses the adjacency matrix where it should use the links matrix (= adjacency_matrix ^ 2).

I am planning to submit a pull request soon to correct this.

JosephChataignon avatar Nov 18 '21 10:11 JosephChataignon