Anatoly Myachev comments

Results 197 comments of


                                            Anatoly Myachev

Speed up tests

> Think more what we run regarding ASV - whether we really care about that in PRs, or maybe we can drop this from PRs and instead run this on...

FIX-#2552: fix certain `loc` assignments when internal lookups are sorted

too old

PERF-#4711: avoid `to_pandas` call when calling left join

Too outdated

PERF-#4777: Don't use `copy=True` parameter for `concat` calls inside `to_pandas`

I don't know what else I can do here

PERF-#4777: Don't use `copy=True` parameter for `concat` calls inside `to_pandas`

~Blocked by https://github.com/modin-project/modin/pull/6706~

TEST-#2073: Check that read_csv can use a parse_dates dict.

> The CI shows a legitimate test failure in `modin/experimental/pandas/test/test_io_exp.py::TestCsvGlob::test_read_single_csv_with_parse_dates[dict]`. I need to add handling of `parse_dates` `dict` in `read_csv_glob`. @mvashishtha could you rebase and see if this error remains

TEST-#2073: Check that read_csv can use a parse_dates dict.

> @mvashishtha let's skip dict case for read_csv_glob and create separate separate issue for that

TEST-#2073: Check that read_csv can use a parse_dates dict.

@mvashishtha https://github.com/modin-project/modin/issues/5326

FIX-#4135: Drop nuisance columns after rolling functions.

@mvashishtha the problem reproducer will throw `pandas.errors.DataError: Cannot aggregate non-numeric type: object` for both Modin and pandas. ```python import modin.pandas as pd df = pd.DataFrame({"a": [1], "b": ["x"]}) df.rolling(window=1).min() ```...

FIX-#3180: Stop defaulting to pandas for paths relative to home.

Fixed in https://github.com/modin-project/modin/pull/6448.