waka-readme-stats icon indicating copy to clipboard operation
waka-readme-stats copied to clipboard

Fixed `TypeError` when commit is being null.

Open AyushAgnihotri2025 opened this issue 2 years ago • 5 comments

Closes #463 Closes #425

AyushAgnihotri2025 avatar Jul 17 '23 16:07 AyushAgnihotri2025

Merging when?

willnaoosmith avatar Aug 10 '23 10:08 willnaoosmith

I personally can't merge the PR until the CI workflow runs successfully and I also can't launch the workflow. I think, it should be triggered on push. @AyushAgnihotri2025, @willnaoosmith, could you please make sure the workflow runs successfully and, if not, investigate logs and fix errors?

P.S. also, if it's not a big deal, I would prefer if commit is not None: syntax as it is more explicit and clear.

pseusys avatar May 02 '24 13:05 pseusys

@pseusys it finally did run correctly again! @AyushAgnihotri2025 Thanks for the help!

willnaoosmith avatar May 06 '24 10:05 willnaoosmith