botologist
botologist copied to clipboard
anlutro
Dota 2 plugin
added moop (this should go in config)
gpm and xpm
Typo with m/p
api keys are long_text_style
Let's show radiant/dire
Remove pprint and close that bracket
Remove this envs file, use config instead
Get rid of envs and keep everything in the config
Use the config for the api key
What's the point of the .db.empty file? The python sqlite module will create the file if it does not exist.
Can you add the pip requirement to requirements.txt?
The point was just so you could copy it to the directory. You'd need the creation logic if it wasn't there though right? I'll add the CREATE TABLE if you'd prefer.
I did have the dota2api requirement in there but it was failing your Travis CI build because, well: https://travis-ci.org/anlutro/botologist/jobs/153921870
Seems it's looking for requests which has been downloaded but not installed at that point.
@anlutro empty db no longer required and added the requirement, it breaks Travis though.
Weird. Try changing travis.yml so it upgrades pip to a more reasonable version:
install:
- pip install --upgrade pip
- pip install -r requirements_dev.txt
Got it working installing requests separately before the pip install -r requests_dev.txt — is this a fine solution do you reckon?
https://github.com/anlutro/botologist/pull/71/commits/b121216040f33ce0355c27e52452252053a0eb9a
I think the problem we're encountering is the reason for this commit https://github.com/joshuaduffy/dota2api/commit/ef5c362c1177db2e89b00670eac6e65e8bd3b1d5
I guess pip doesn't allow us to get an un-tagged/released version from github so we should just ask the dota2api author to release a new version.
Get rid of pip install requests in travis.yml and relax the version constraint for dota2api. The bug causing Travis to fail is fixed in 1.3.2 - set the version constraint to >=1.3,<1.4 or something.
Also squash this PR's commits after doing that. A single commit for all the changes here is enough.
:o On 14 Sep 2016 09:46, Anton Amirian [email protected] wrote:oy vey
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/anlutro/botologist","title":"anlutro/botologist","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/anlutro/botologist"}},"updates":{"snippets":[{"icon":"PERSON","message":"@moopie in #71: oy vey"}],"action":{"name":"View Pull Request","url":"https://github.com/anlutro/botologist/pull/71#issuecomment-246946477"}}}