ng2-bootstrap-modal icon indicating copy to clipboard operation
ng2-bootstrap-modal copied to clipboard

Changed <template> to <ng-template> to eliminate Angular2 warning

Open FaterW opened this issue 7 years ago • 20 comments

FaterW avatar May 16 '17 15:05 FaterW

@bikalay please merge

carlmon avatar Jul 10 '17 17:07 carlmon

@bikalay When merge this modify?

Toso82 avatar Jul 13 '17 09:07 Toso82

@bikalay Excuse me, colleagues: what about Fater's changes merge?

e-watson avatar Aug 04 '17 11:08 e-watson

Its better if merge this quickly

anuruddha-thennakoon avatar Aug 19 '17 18:08 anuruddha-thennakoon

I have also same warning on my project. Please merge this change.

BearandYoon avatar Aug 20 '17 14:08 BearandYoon

Please kindly merge this change.

socx avatar Aug 24 '17 20:08 socx

Please merge.

mscoobby avatar Aug 25 '17 09:08 mscoobby

Please merge

bculley avatar Sep 14 '17 18:09 bculley

Please merge the change as soon as possible.

rajavijayavendan avatar Sep 19 '17 10:09 rajavijayavendan

Please do merge

LasithaPrabodha avatar Oct 12 '17 04:10 LasithaPrabodha

please do merge

alessandrov avatar Oct 13 '17 15:10 alessandrov

this warning causes issues while deploying to gae, please merge asap

alessandrov avatar Oct 16 '17 17:10 alessandrov

please...

nviospvkuadt avatar Oct 20 '17 16:10 nviospvkuadt

please do merge

luisgagocasas avatar Oct 26 '17 02:10 luisgagocasas

Please merge buddy... ng5 is out now.. we want to upgrade

kevcjones-archived avatar Nov 04 '17 02:11 kevcjones-archived

I've made a fork - merged this and the this https://github.com/ankosoftware/ng2-bootstrap-modal/issues/49#issuecomment-342558956 fix to make it angular5 compatible.

Until the author returns i'll maintain this one and hopefully can fold anything back into this one. It was do this OR change package, and maybe some of you here can step sideways while we wait. Hopefully its clear enough in the readme, and of course since its a 'forked' repo that i'm not stealing or taking any credit for this authors work. I simply want an error free upgrade 👍

https://github.com/kevcjones/angularx-bootstrap-modal

[edit] Our branch is actually deviating quite a bit now and we're making some breaking changes but the premise is the same just without Bootstrap dependencies and refactoring code with tests etc.

https://github.com/kevcjones/ngx-simple-modal

kevcjones-archived avatar Nov 10 '17 16:11 kevcjones-archived

@KevCJones I've noticed your fork doesn't have an issue tab. I think it would be a must, since the idea is to keep the project updated. I'll try to keep up with your version until this one get's it's attention back, or just keep rolling with yours.

celsomtrindade avatar Nov 10 '17 21:11 celsomtrindade

The author will merge?

fonsecapontes avatar Dec 01 '17 18:12 fonsecapontes

please do merge

akhsunna avatar Dec 11 '17 16:12 akhsunna

please do merge

Lizonchik avatar Dec 11 '17 16:12 Lizonchik