ankor2023

@rousskov Alex, thank you for the comments. > If possible, please adjust PR description to explicitly disclose how/whether these changes affect existing helper deployments and to briefly note how the...

> I think the Kerberos helper is too important for the squid-users, and it would be nice to keep its support. Since the code of the Kerberos helper has been...

> The change looks fine i.e. is in line with the way I extract SIDs and resource groups are relevant for some cases of forest trusts. I am only surprised...

@huaraz: Hello, Markus, The code uses RPC_UNICODE_STRING data structures: ``` typedef struct { uint16_t length; uint16_t maxlength; uint32_t pointer; } RPC_UNICODE_STRING; ``` It corresponds to the Microsoft [article](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/94a16bb6-c610-4cb9-8db6-26f15f560061). I can't...

@rousskov, @yadij : Hello, Alex and Amos, The PR has **s-waiting-for-author** tag. Do I need to take any action on my part? Kind regards, Ankor.

> Ignoring most of the formatting for now. There are some potential error cases that seem important to handle. @yadij Hello, Amos, Thank you very much for the review! I...

> Ignoring most of the formatting for now. There are some potential error cases that seem important to handle. @yadij : Hello, Amos, I posted a new version of the...

> > @yadij requested a review from rousskov on December 5, 2023 02:19 > > My position has not changed since [#1597 (review)](https://github.com/squid-cache/squid/pull/1597#pullrequestreview-1744593768) > I suggest declaring the whole helper...

> There are currently three core developers: @kinkie, @yadij, and @rousskov. @kinkie , @yadij , @rousskov You are three programmers and you support and develop such a complex system. I...

@yadij Hello, Amos, Thank you so much for such a detailed and valuable review. I will try to take into account all your comments and correct the code in the...