tus-php
tus-php copied to clipboard
fix: Lock file on windows
On Windows write data that FileStore.php is programmed cause
Write of xx bytes failed with errno=13 Permission denied
This is because the program call file_put_contents and filesize (that always return 0) methods on a locked file
From 14 PHPUnit test on Windows errors, on my implementation now have only 3 (that is non-related), this don't add any errors, only fix some existent errors
Codecov Report
:exclamation: No coverage uploaded for pull request base (
main@f50852b
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage ? 99.59%
Complexity ? 367
=======================================
Files ? 20
Lines ? 981
Branches ? 0
=======================================
Hits ? 977
Misses ? 4
Partials ? 0
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Can you merge this PR. Upload doesn't work on Windows systems without this patch.
Hi @thide11, sorry for responding to this late. I couldn't manage to check it in Windows but since few folks reported that this fixes the issue in windows and is not breaking anything on other systems, I am going to merge this.
Thank you for your contribution π