Ankit Khushwaha

Results 51 comments of Ankit Khushwaha

hello @matteobachetti , @dhuppenkothen please let me know if this assign with your thoughts and do the changes accordingly

hey @nabobalis i have fixed this issue but this branch has changes from pr [#7922](https://github.com/sunpy/sunpy/pull/7922) should i create a new pr and closing pr #7922 or just make commit in...

some unit test are failing without # 7992 , that i have fixed in # 7922 i have made change in same file

> As it stands, this does not really integrate with the release workflow and I think that needs thinking about before we continue with this PR. Are there specific steps...

i have extended the ci.yml instead of creating a new action.

> Should this into the package template repo instead since this should be rolled out to every sunpy package? if we are fine with [#181](https://github.com/sunpy/package-template/pull/181) we should close this in...

closing it https://github.com/sunpy/package-template/pull/181

The example mentioned in https://github.com/sunpy/sunpy/blob/782b242b06724ae315e9aad776c7673b895e3585/sunpy%2Ftimeseries%2Ftimeseriesbase.py#L66 Has astropy time

is user expected to give `Pandas.Timestamp` or `Astropy.Time` ? It is somewhat tricky, as user working with sunpy library will tends to use `Astropy.Time` more often. But in some of...

I have tested the code with `pandas.TimeStamp` and `Astropy.Time` everything is working fine just i have to add some unit tests Then should i change the example discussed in `GenericTimeSeries`...