Feat/Different method for ratio graph in Help Me Decide.

[Luc-Mcgrady]

Forum link:

• https://forums.ankiweb.net/t/replace-cmrr-with-workload-vs-dr-graph-more/63234/27?u=a_blokee

@snorpdorp notified me that the logic behind the ratio graph is flawed as it doesn't properly account for the number of cards that are memorized to begin with.

I have implemented his (and @1DWalker's) proposed solution

Now the graph is inverted so that the higher the value, the more efficient it is, in @snorpdorp's own words:

The previous equation was flawed in that it displayed the total knowledge at the end of the simulation, not the relative gain in knowledge from the amount of studying done during the simulation timeframe. The new (correct) equation is (relative gain in knowledge as a result of studying during the simulation) / (time spent studying during simulation) - https://discord.com/channels/368267295601983490/1443273721878937650/1444447278344437833

[Mirza-Samad-Ahmed-Baig]

Good Catches.

[SyedaAnshrahGillani]

Nice! How does this apply to the model.delete_checkpoints method? I can imagine a backup of old checkpoints that isn't automatically synced to s3 being useful.

That's a great question,

You're right, the current implementation of the trash feature is focused on the model as a whole and doesn't extend to the delete_checkpoints method. The delete_checkpoints function still deletes the checkpoints permanently from the local filesystem.

I think applying a similar "trash" concept to checkpoints is an excellent idea for a future enhancement. It would provide a safety net for local checkpoints that haven't been synced to S3. I can create a new issue to track this feature.