anki icon indicating copy to clipboard operation
anki copied to clipboard

Implement some Flexible Grading features as a Reviewer

Open tatsumoto-ren opened this issue 1 month ago • 5 comments

https://github.com/ankitects/anki/pull/4289 breaks add-on compatibility, and I'm afraid it means Flexible Grading might stop working someday. I want to add an alternative code path that implements some Flexible Grading features without using WebViews.

Since https://github.com/ankitects/anki/pull/4289 implements a new reviewer by subclassing the default, I think it makes sense to implement some Flexible Grading features the same way: as an alternative reviewer. This would follow up on https://github.com/ankitects/anki/pull/2502 since the ability to configure answer keys was originally unique to Flexible Grading too.

https://github.com/ankitects/anki/pull/4289 goes the wrong direction: it is overly complicated, wastes screen space, and is slower than a native Qt UI. I'd like to be able to opt out permanently, as I suggested in this comment:

I think it's better to tackle the issue from a different angle. Add preferences to "opt out of Webview screens". So, when you enable this option (or a subset of options), you would get a native UI instead.

tatsumoto-ren avatar Nov 24 '25 02:11 tatsumoto-ren

Submitted this PR https://github.com/ankitects/anki/pull/4444

tatsumoto-ren avatar Nov 24 '25 08:11 tatsumoto-ren

Has Dae left the project?

tatsumoto-ren avatar Nov 30 '25 09:11 tatsumoto-ren

Has Dae left the project?

No. Why would you think that?

GithubAnon0000 avatar Nov 30 '25 10:11 GithubAnon0000

No. Why would you think that?

@GithubAnon0000 Last time he was active on the Anki Forums was more than a month ago. And he doesn't comment on GitHub anymore. https://forums.ankiweb.net/u/dae/activity I'm wondering who's in charge now. I believe Abdo is an admin in this repository. But Abdo doesn't seem to review new PRs either.

tatsumoto-ren avatar Nov 30 '25 11:11 tatsumoto-ren

Sometimes it takes a few weeks. Though I admit in the last month it did take much longer than normal. Normally, PRs have been reviewed in 1 – 2 weeks.

Maybe dae is just very busy with life right now. abdnh / Abdo did review one of my PRs just a week ago; so he's certainly still reviewing PRs.

Let's just wait for another week or two, one of those two will probably comment on / review the PRs by then.

GithubAnon0000 avatar Nov 30 '25 11:11 GithubAnon0000