anki icon indicating copy to clipboard operation
anki copied to clipboard

Reviewer shouldn't need to read FSRS config on every card answer

Open user1823 opened this issue 2 months ago • 3 comments

Currently, the reviewer reads the config on every card answer to know whether FSRS is enabled. This has performance costs.

https://github.com/ankitects/anki/blob/321e23acb2b02d657ca08727546c016d7ef27381/rslib/src/scheduler/answering/mod.rs#L449

We should be able to optimize this by making some changes similar to https://github.com/ankitects/anki/pull/3860.

Originally posted by @user1823 in https://github.com/ankitects/anki/issues/4391#issuecomment-3405522828

user1823 avatar Oct 16 '25 14:10 user1823

Hi!

@matbe766 and I would like to work on this issue together. Just wanted to check if it’s still relevant and open for contribution.

Thanks!

Hannanilsenn avatar Nov 03 '25 10:11 Hannanilsenn

Yes, this is still open. But, looking at the linked load balancer PR, it feels like fixing this issue will require a good understanding of the codebase.

user1823 avatar Nov 03 '25 10:11 user1823

Thanks!
We’ll take a look at it and see if we can come up with a possible solution.
Then we can discuss it further.

Hannanilsenn avatar Nov 03 '25 11:11 Hannanilsenn