PyCNN icon indicating copy to clipboard operation
PyCNN copied to clipboard

Rename variables

Open ankitaggarwal011 opened this issue 9 years ago • 9 comments

Please note these guidelines while renaming variables.

  • Do not rename the parent class.
  • Rename the variables or methods to have more intuitive names.
  • Use private variables where necessary. You can use this or this guide.
  • Document the corresponding changes in README.

Any suggestions are welcome. Thanks.

ankitaggarwal011 avatar Oct 08 '16 09:10 ankitaggarwal011

What files would you like renamed? :)

gregJohnRob avatar Oct 08 '16 12:10 gregJohnRob

Hi, can I take this up?

pratyushprakash avatar Oct 08 '16 13:10 pratyushprakash

@gregJohnRob, the goal of this issue is to rename all the variables and methods in the code to ensure easier understandablity and readability. This will span over the entire code-base that can be improved. This is a subjective issue and would require thorough review.

@pratyushprakash, if @gregJohnRob isn't taking up this issue, you can go ahead. Please wait until he comment about it. Thanks.

ankitaggarwal011 avatar Oct 08 '16 14:10 ankitaggarwal011

@pratyushprakash I don't mind if you want to take it :)

gregJohnRob avatar Oct 08 '16 14:10 gregJohnRob

@pratyushprakash, please let us know if you're working on this issue. Thanks.

ankitaggarwal011 avatar Oct 08 '16 18:10 ankitaggarwal011

@ankitaggarwal011 Yeah I'd be happy to.

pratyushprakash avatar Oct 08 '16 18:10 pratyushprakash

I am no longer working on the issue. Please feel free to take it up as it still requires work. :)

pratyushprakash avatar Oct 10 '16 18:10 pratyushprakash

Hello. This project looks interesting. I'll be happy to take a look at this issue. I'll let you know if I have any questions.

insomnious0x01 avatar Oct 10 '16 22:10 insomnious0x01

@dhetman, thanks. Please go ahead. Thank you for your help.

ankitaggarwal011 avatar Oct 11 '16 06:10 ankitaggarwal011