Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Test for currentdeckid

Open aladdin-afk opened this issue 1 month ago • 5 comments

Purpose / Description

This PR addresses the missing test coverage for the Card.currentDeckId() function

Fixes

  • Fixes #13283

Approach

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • [ ] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [ ] You have commented your code, particularly in hard-to-understand areas
  • [ ] You have performed a self-review of your own code
  • [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

aladdin-afk avatar Dec 10 '25 16:12 aladdin-afk

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

welcome[bot] avatar Dec 10 '25 16:12 welcome[bot]

sorry for this, will continue tomorrow

aladdin-afk avatar Dec 10 '25 16:12 aladdin-afk

Please run your tests locally and push when they're working Don't just push and push and push (and generate notifications for maintainers that watch the repo) please

mikehardy avatar Dec 10 '25 20:12 mikehardy

sorry i will look for fixing it in local

aladdin-afk avatar Dec 10 '25 20:12 aladdin-afk

oh mybad, i just realised.sorry for the wrong commit.

aladdin-afk avatar Dec 11 '25 08:12 aladdin-afk

@aladdin-afk Please mark as 'Ready for review' if it's ready for review. I almost skipped over the notification as tihis was a Draft 😓

david-allison avatar Dec 11 '25 22:12 david-allison

Ah, forgot about the override comment, that's a minor blocker

if it was the helper function, i did remove it. if not pls tell i will change it.

aladdin-afk avatar Dec 13 '25 01:12 aladdin-afk