Anki-Android
Anki-Android copied to clipboard
Migrate `AsyncDialogs` to Material 3
Description
Currently the issue was that the colour of the checkbox was not matching with the APP theme @color/material_light_blue_500
. Initially, my thought process was to add a style in the Theme to ensure the checkbox color matches the app theme. However, I later realized that migrating to Material3 would be a better approach, as it allows the checkbox color to adapt dynamically based on the app theme. Since we plan to migrate to Material3 eventually, this seems like the most forward-thinking solution.
-
🌟 h/t to thank @SanjaySargam for helping inspire this solution with #15184
-
🌟 h/t to thank @Thejas775 for helping inspire this solution with #16485
Fixes
- Fixes : #15174
- Related : #13878
Steps to Reproduce
- App Info
- Go to Manage Space
- Click on Delete backups
- Click on any one of the Checkbox Item
Screenshot/Video
https://github.com/ankidroid/Anki-Android/assets/60827173/d72e6ef2-66be-48ab-a0a2-00378ed5e7dc
Approach
In the PR :)
Learning (optional, can help others)
https://github.com/material-components/material-components-android/blob/master/docs/components/Dialog.md
Checklist
Please, go through these checks before submitting the PR.
- [X] You have a descriptive commit message with a short title (first line, max 50 chars).
- [X] You have commented your code, particularly in hard-to-understand areas
- [X] You have performed a self-review of your own code
- [X] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
- [ ] UI Changes: You have tested your change using the Google Accessibility Scanner