Update:twitter logo

[shrutigitte]

Purpose / Description

I forked the ankidroid repo today and I am a new contributor so I am eager to contribute so I decided to start with minor refractor.

How Has This Been Tested?

It's a PNG file and doesn't need testing

Checklist

Please, go through these checks before submitting the PR.

• [x] You have a descriptive commit message with a short title (first line, max 50 chars).
• [x] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

[welcome[bot]]

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

[shrutigitte]

I have downloaded the logo from the official Twitter Developer Kit following their guidelines.

[BrayanDSO]

I question if we have to include some kind of "X logo is from X, and is not affiliated with AnkiDroid" kind of message. A link to the logo distribution docs would help

[shrutigitte]

https://about.x.com/en/who-we-are/brand-toolkit

I downloaded the icon from here i don't think there is need to write anything extra this is especially for the purpose of using X logo on websites/Apps

[criticalAY]

Still look good to me

[david-allison]

Could we resize this back to 400x400?

Sorry this sat for so long

[shrutigitte]

Could we resize this back to 400x400?

Sorry this sat for so long

The photo is already 50 in the place it is used. <a href="https://twitter.com/ankidroid"><img src="docs/graphics/logos/twitter_logo_color.png" height="50px"/></a>

[snowtimeglass]

I suspect the white logo with transparent background would be invisible when the background of the page is white.

[david-allison]

It's more that it's a large file, and it adds to the git clone/CI time unnecessarily. If we only need 50x5, even better!

[criticalAY]

@snowtimeglass @david-allison How about we use this, and it is given by twitter/X itself

[david-allison]

Looks nice

[snowtimeglass]

@criticalAY

How about we use this

I'm still not sure which part you point to. Do you point to this wide rectangle PNG image as a whole? (Or the "X" logo, which was made as a font or something?)

Also, doesn't that jaggedness occur in the actual page?

[snowtimeglass]

I think it is desirable to use just an PNG icon like the others:

The following material and the site look trustworthy and useful to me.

https://www.iconpacks.net/free-icon/twitter-x-logo-black-round-20851.html

https://www.iconpacks.net/terms/

---

Maybe it is possible to provide an adjusted PNG image based on the material above (or a material from twitter/X's site) here.

[mikehardy]

@snowtimeglass I love the idea of a 50px PNG that is always white X on black background, if you did that and proposed it I would merge it paired with #16828

[david-allison]

Great stuff, thanks

[Arthur-Milchior]

At this point, I'd suggest also renaming the file. Won't block on it. Thanks @shrutigitte

[snowtimeglass]

The current pushed icon looks blur, jaggy (and no padding), unlike the other icons' images.

(Original size: 64 × 64 px)

(Original size: 400 × 400 px)

(Original size: 400 × 400 px)

---

@mikehardy

if you did that and proposed it

Thank you. I would gladly do so. On the other hand, I can also provide the image file here. Either way is fine for me. (Original size: 400 × 400 px)

The PNG image file is here. x-logo-adjusted.zip

[snowtimeglass]

@mikehardy Ah, I just noticed that you commented that 4 days ago. I overlooked it until now.

[mikehardy]

"This job failed" is as much information as I could get out of the merge queue failure, not really informative. Was the windows unit test run that failed.

Put it back in the queue...

[github-actions[bot]]

Hi there @shrutigitte! This is the OpenCollective Notice for PRs merged from 2024-08-01 through 2024-08-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

[!IMPORTANT] PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!