Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

[suggestion] Add AnkiWeb logo to 'AnkiWeb account' screen

Open snowtimeglass opened this issue 1 year ago • 7 comments

As a desirable approach on the client (AnkiDroid) side, I suppose that it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading. image

In case that an app has a screen for connecting to Twitter/X, it is natural to use Twitter/X logo in the screen, rather than the logo of the app itself (only).

I would think the same is true for the screen for connecting to AnkiWeb.

Originally posted in https://github.com/ankidroid/Anki-Android/issues/16260#issuecomment-2084674323

snowtimeglass avatar Apr 30 '24 11:04 snowtimeglass

it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

That is, for example,

  • Simply replacing AnkiDroid logo with AnkiWeb logo

  • Displaying the two logos to visualize the independence of the app (AnkiDroid) and the external service (AnkiWeb) from each other.

    [Reference]

    [image]

(Anyway, the current logo on the screen may be a bit too big.)

Originally posted in https://github.com/ankidroid/Anki-Android/issues/16260#issuecomment-2084718548

snowtimeglass avatar Apr 30 '24 11:04 snowtimeglass

I agree with @snowtimeglass , having a good UI on that screen would be helpful understanding the flow of what exactly is happening

oyeraghib avatar Apr 30 '24 15:04 oyeraghib

I've labeled this as https://github.com/ankidroid/Anki-Android/labels/Good%20First%20Issue%21

The first step would be to propose a vector icon which:

  • Fits the requirements above
    • #ankidroid-design on Discord if you need more real-time feedback
    • Bring the results of these discussions back to the issue
  • Can be modified to work in Night Mode
  • Will work Landscape + Portrait
  • Works on both the 'MyAccount' and LoginActivity screens
    • Log In + Logged In: we don't handle sign up
    • Do not make the image larger vertically. We can probably handle smaller
  • Have a brief think about tablets

You'll likely want to work with a placeholder for the AnkiWeb logo, then once the design seems reasonable, confirm with @dae that we're OK to use the logo in the design, and an appropriate license for it.

david-allison avatar May 01 '24 15:05 david-allison

Hi, can I work on this issue. New to open source contribution, hence would like to pitch in.

tamojitdas avatar May 04 '24 13:05 tamojitdas

That's great! Thanks

david-allison avatar May 05 '24 02:05 david-allison

Currently coming up with the logo design and placement along with caption, will get it verified tommorow on discord by @david-allison and @dae

tamojitdas avatar May 06 '24 18:05 tamojitdas

Great! No need to ping unless there's something for me to do

david-allison avatar May 06 '24 18:05 david-allison

any updates on this i wanna try

devharsh2k4 avatar May 11 '24 19:05 devharsh2k4

sure @devharsh2k4 will let u know

tamojitdas avatar May 11 '24 19:05 tamojitdas

HI @dae @david-allison @snowtimeglass require necessary feeds and confirmation for the following updated layout The Changes are done ..can raise a PR post confirmation Login Page + loggedIn Page: logInPage loggedInPage

tamojitdas avatar May 12 '24 20:05 tamojitdas

Also, just in case, if you require to see landscape: loggInPageLandscape

tamojitdas avatar May 12 '24 20:05 tamojitdas

Thank you for the work and the draft.

Some concerns and expectation:

  • I'm not sure that using "Authorize" here is appropriate. "Connect to AnkiWeb" might be better. image

    • Accordingly, the checkmark icon may also need to be reconsidered. image
  • The design of "connecting" seems to have room for improvement (in the future). The current black dots don't look very good to me. image


    image image image

    • Using AnkiWeb image only is also alternative.
  • The outline rectangle (shade) of the image looks unnecessary to me. image

  • Spacing between images and the label and the input box looks narrow. image

  • The AnkiDroid image needs to be revised to more "official" one. imageimage

  • "AnkiWeb" text in the logged-in screen appears to be compressed vertically. It may be not desirable.


    image

snowtimeglass avatar May 13 '24 11:05 snowtimeglass

alright will work on this

tamojitdas avatar May 13 '24 12:05 tamojitdas

@snowtimeglass @david-allison @dae pls take a lookimageimage

tamojitdas avatar May 20 '24 12:05 tamojitdas

@tamojitdas you should come to the design channel on our Discord to get more instant feedback (#ankidroid-design)

And no need to ping dae, all that's needed is a final sign-off that he's ok with the AnkiWeb logo use, and an appropriate licence for us to use

david-allison avatar May 20 '24 19:05 david-allison

Thank you, it generally looks better to me.

I too think posting it on Discord may be a good idea. You may want to take and use high-resolution screenshots for that. image

I feel it might be even better if the vertical margins around the image area were a little wider.

image

image

"Connect To": "Connect to" (sentence case style) would be desirable as it is consistent with the notation of the other labels in this app. image

Thanks again.

snowtimeglass avatar May 22 '24 12:05 snowtimeglass