Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

suggestion: Make the default flag stroke thicker

Open snowtimeglass opened this issue 10 months ago • 7 comments

The thickness of the default flag (ic_flag_transparent) stroke is less consistent with other icons. image image I (maybe) understand its intent to express transparency, but it may work even with the same thickness as the neighboring star, which works in a similar role.

For example: image image

Alternative example: (the width of the pole is wider than the colored flag's one) image image

Additional context Anki Desktop image

snowtimeglass avatar Apr 23 '24 10:04 snowtimeglass

Good first issue

criticalAY avatar Apr 23 '24 10:04 criticalAY

@snowtimeglass Which stroke width looks good for the default flag? image (4)

Giyutomioka-SS avatar Apr 23 '24 11:04 Giyutomioka-SS

I like 1.5, I think the actual 'best' value will be somewhere between 1.5 and 1.75

david-allison avatar Apr 23 '24 11:04 david-allison

@Giyutomioka-SS

The width of the star stroke is about 1.6. However, simply making the flag stroke thicker would make the size difference from the colored flags conspicuous. In other words, the flag would become conspicuously smaller when it gets colored.

Also, the inside of the pole would become too thin by the simple adjustment.

I think these results are undesirable.

If this suggestion (I mean, general proposal of this topic: "make the default flag stroke thicker", not a specific design above) is accepted, I would like to submit a PR. image

snowtimeglass avatar Apr 23 '24 11:04 snowtimeglass

@snowtimeglass R u working on this?

Giyutomioka-SS avatar Jun 18 '24 18:06 Giyutomioka-SS

Thanks for the interest.

I have held of on working on it with waiting the suggestion (the basic idea of making the default flag stroke thicker) is accepted.

~However, perhaps it might be better to submit a PR as a specific idea, in order to assess this suggestion. For now, I intend to resume work on it.~

snowtimeglass avatar Jun 19 '24 01:06 snowtimeglass