Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Enhancement: allow renaming flag from CardBrowser menu

Open criticalAY opened this issue 10 months ago • 4 comments

Purpose / Description

  • #16205, Anki allows flag to be renamed from card browser so replicating that this PR provides a menu option through which we can rename the flag and after sync the same is reflected in Anki desktop

Fixes

  • Fixes #16205

How Has This Been Tested?

image

AnkiDroid: (orange flag) Screenshot 2024-04-22 144750

Anki after sync: image

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

criticalAY avatar Apr 22 '24 09:04 criticalAY

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

github-actions[bot] avatar Apr 22 '24 09:04 github-actions[bot]

I have placed the rename option in menu for now, reason too many steps would be required in that case Menu -> Options dialog -> Rename flag -> One more dialog consisting of the list of flag -> flag clicked -> another rename dialog

We can place the rename option just above the Options maybe?

criticalAY avatar Apr 22 '24 09:04 criticalAY

image

image

criticalAY avatar Apr 22 '24 16:04 criticalAY

image image image

criticalAY avatar Apr 22 '24 20:04 criticalAY

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar May 13 '24 18:05 github-actions[bot]

Cheers, I'm out of office for now, string sync then merge at will

david-allison avatar Jun 17 '24 14:06 david-allison

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

github-actions[bot] avatar Jun 17 '24 17:06 github-actions[bot]

First of all, thanks for the great work. I think that not a few users have been looking forward to this useful feature.

It seems that pressing "Cancel" button (at the bottom of the following dialog box) doesn't cancel flag names edited and "checked"(✓) on the spot.

Even then, is it desirable to place the "Cancel" and "OK" button in the dialog box? For now, I'm a bit concerned whether the role of "Cancel" button might be confusing. Is no button (or single button, "Close") not good in this case?

snowtimeglass avatar Jun 20 '24 11:06 snowtimeglass

Hi there @criticalAY! This is the OpenCollective Notice for PRs merged from 2024-06-01 through 2024-06-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

[!IMPORTANT] PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

github-actions[bot] avatar Sep 15 '24 22:09 github-actions[bot]