Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Add: Remove button for deck picker background image

Open oyeraghib opened this issue 4 months ago • 3 comments

Purpose / Description

Add: Remove button for deck picker background image

Fixes

  • Fixes #16090

Approach

Created a custom preference for adding the option to remove the image along with selecting the image.

Before

https://github.com/ankidroid/Anki-Android/assets/40427461/ec776769-51ce-4efd-b652-e10414f766fb

After

https://github.com/ankidroid/Anki-Android/assets/40427461/1137b97e-c08d-4bc0-9e96-8234aa499f8d

How Has This Been Tested?

Tested on: Physical device - Pixel 6A (Android 13) Emulator - Pixel 3a (Android 14)

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [x] UI Changes: You have tested your change using the Google Accessibility Scanner

oyeraghib avatar Apr 04 '24 06:04 oyeraghib

I'd suggest best and simple way: Change text if image is selected -> Remove image else -> Select image

SanjaySargam avatar Apr 04 '24 13:04 SanjaySargam

@SanjaySargam I think the problem with this approach would be replacing the image. If there is already a bg image and user decides to change to new image, first they have to remove the prior image and then they would get the option to "Select image", which I think is an extra unnecessary step from user's pov.

oyeraghib avatar Apr 04 '24 18:04 oyeraghib

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Apr 27 '24 16:04 github-actions[bot]