ankidroid
"Discard current input?" is not suitable for existing-content-editing screens ("Edit note", "Deck options", "Card type")
I would also propose to change the wording to "Discard changes?" in case changes were made, since any user actions in the deck options are rather "changes" and not "input". Should I open an extra issue for that?
Originally posted by @camoz in https://github.com/ankidroid/Anki-Android/issues/15782#issue-2169625911
What about changing "Discard current input?" to "Discard changes?" or similar (cf. last paragraph I wrote)?
Originally posted by @camoz in https://github.com/ankidroid/Anki-Android/issues/15782#issuecomment-1979260121
The opinion seems right not only from the viewpoint of meaning but also from the viewpoint of consistency with Anki Desktop.
Actually, in Anki Desktop, "Discard current input?", is used just for "Add" screen; it isn't used for the following screens: "Edit note", "Deck options", "Card type".
https://github.com/search?q=repo%3Aankitects%2Fanki+%22adding_discard_current_input%22&type=code
It means that this string is used just in case that a new note is created and is input something, not in cases that existing (= already-saved) contents is edited. I'd say that this string is optimized for new creation and is not suitable for other situations.
However, in AnkiDroid, "Discard current input?" is used not only for "Add" screen, but also for those existing-content-editing screens ("Edit note", "Deck options", "Card type"). In these cases, this message looks a bit odd and less intuitive, as @camoz may feel.
So, for the screens ("Edit note", "Deck options", "Card type"), it will probably be better to reuse "Discard changes?" from Anki Desktop. It will work more clearer, more intuitive, less confusing in the situations, as it works in Anki Desktop as follows:
I agree that it's better to reuse "Discard changes?" from Anki Desktop in cases where existing content is being edited.
However, the options "Discard" and "Keep Editing" should remain unchanged.
For example, the following dialog appears in Google Photos when leaving the editing screen:
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
Hey @david-allison ! Looks like this is still open. Could I give this a go? It would be my first contribution.
