add "flag menu" control during review

[rickyribeiroo]

Is your feature request related to a problem? Please describe. During review, flags can be toggled individually by key, joystick / motion controller, or gesture. However, there's no control to just show the flags menu (similarly to "Add tag").

Describe the solution you'd like I'd like to see a control option for "Add flag" that would show the flags menu, giving the user the option to then choose a flag from that menu during review.

[welcome[bot]]

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

[BrayanDSO]

I like it, but would show a dialog instead of the options menu, since the menu wouldn't look natural if the toolbar is hidden. The dialog would be either a vertical one or a 3x3 grid one, with the flags icons and names, whichever looks better

[rickyribeiroo]

Good idea!

On Tue, 27 Feb 2024 at 22:17, Brayan Oliveira @.***> wrote:

I like it, but would show a dialog to pick a flag instead. Either a vertical one or a 3x3 grid one, with the flags icons and names

— Reply to this email directly, view it on GitHub https://github.com/ankidroid/Anki-Android/issues/15697#issuecomment-1967605016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOEEM2QZZVDVORVLQWB7GP3YVZEOJAVCNFSM6AAAAABD4S7G7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXGYYDKMBRGY . You are receiving this because you authored the thread.Message ID: @.***>

[divyesh-mali]

Hi @david-allison
I'm excited to see this feature implemented in AnkiDroid. I'd be happy to contribute by working on the flag selection option during review. I've followed the discussion regarding menus vs dialogs, and I'm open to collaborating on the best approach. Can you please assign this issue to me? I'm eager to get started and discuss any specific details you may have.

[divyesh-mali]

Hi @rickyribeiroo
I'm currently working on resolving this issue. Correct me if I'm wrong, you want option for "Add flag" when we create the card right? (as shown below in screenshot)

Because we already have the option to "add flag" while we are viewing the card normally in a deck.

[david-allison]

Not there (I presume in the reviewer).

A flag belongs to a card, not to a note, so it shouldn't be a concern of the note editor

[rickyribeiroo]

Exactly, I mean openning the flag menu through a gesture / controller / button when reviewing a card, the same way the option "add tag" exists in the Gestures settings.

Thank you!

On Mon, Mar 11, 2024, 18:59 David Allison @.***> wrote:

Not there (I presume in the reviewer).

A flag belongs to a card, not to a note, so it shouldn't be a concern of the note editor

— Reply to this email directly, view it on GitHub https://github.com/ankidroid/Anki-Android/issues/15697#issuecomment-1989101996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOEEM2QVWGL2Y3JOEMUCGA3YXXWI7AVCNFSM6AAAAABD4S7G7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGEYDCOJZGY . You are receiving this because you were mentioned.Message ID: @.***>

[divyesh-mali]

hey @rickyribeiroo can we connect on discord? I would like to discuss some things regarding this issue. My discord username is divyesh.mali

[david-allison]

Make sure you document the result of the conversation here, Discord isn't searchable

[divyesh-mali]

Summary of Discord Conversation with @rickyribeiroo :

I reached out to rickyribeiroo on Discord seeking clarification regarding the issue of adding flags during review in Ankidroid. rickyribeiroo explained the feature request, aiming to add functionality similar to the existing "Add tag" feature. He advised me to experiment with the "Add tag" feature to understand its functionality better. I agreed to proceed with implementing the "Add flag" feature and expressed gratitude for the guidance and I'll be trying my best to working on implementing this feature.

[david-allison]

(light mentoring): In future, just list what other people need to know

It was explained that the functionality should be similar to the "Add tag" screen

[divyesh-mali]

Thank you for the feedback. I've properly understood the issue and have done some work on it but unfortunately I would not be able to work on this issue for some upcoming days because from 20 March to 27 March there are my college In-semester exams. I will resume my work immediately after that. Sorry for the inconvenience.

[david-allison]

No worries! Education takes priority!

[RedLexa]

Hello! I am considering restarting work on this enhancement, and want to make sure I understand what is being requested here.

I like it, but would show a dialog instead of the options menu, since the menu wouldn't look natural if the toolbar is hidden. The dialog would be either a vertical one or a 3x3 grid one, with the flags icons and names, whichever looks better

I understood @BrayanDSO's suggestion of the dialog instead of the menu. But what exactly is the functionality in this dialog that isn't already present in the menu flag card (that shows up next to the undo icon on the toolbar)? If I am understanding correctly two things are being asked:

1. The dialog would show the flags menu.
2. The user then choose a flag from that meny during review.

It seems to me that both of these functionalities are already implemented in this menu.

Apologies if I'm missing something obvious.

[david-allison]

The request is to make that menu mappable to a keyboard shortcut/gesture/controller in 'settings -> controls'

[RedLexa]

Thanks for the reply! I see now. My follow-up question would be: would the implementation of this dialog replace the current drop-down menu from the toolbar, even when it's not displayed as a consequence of the control being called?

[david-allison]

I doubt it's worth it, given the menu is simple and close to a user's finger/cursor when they make a press

Do a quick check using Fitts's law if you're included.

[RedLexa]

I'd like to work on this! @david-allison Can you please assign me?

[david-allison]

Thanks!!

[github-actions[bot]]

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically