Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

[BUG]: "Limits start from top" incompatible with increased daily limit

Open virginviolet opened this issue 1 year ago • 5 comments

Checked for duplicates?

  • [X] This issue is not a duplicate

Bug

When the "limits start from top" option is enabled, increasing the daily limit with custom story or increasing the "today only" does not work. It just doesn't increase the number of new cards available. And yes, I'm not out of new cards, of course.

Or maybe it's supposed to be like that and I've misunderstood something.

What are the steps to reproduce this bug?

Long tap a deck, select deck options. Switch on "limits start from top". Save. Long tap any deck, select custom study, then "modify today's daily limit". Enter any positive integer and tap OK.

Expected behaviour

More new cards.

Actual behaviour

No additional new cards.

Debug info

AnkiDroid Version = 2.17.1 (dd2f3762fb214f9dd51162b215974b23cc809713)

Backend Version = 0.1.34-anki23.12.1 (23.12.1 1a1d4d5419c6b57ef3baf99c9d2d9cf85d36ae0a)

Android Version = 14 (SDK 34)

ProductFlavor = full

Manufacturer = samsung

Model = SM-A346B

Hardware = mt6877

Webview User Agent = Mozilla/5.0 (Linux; Android 14; SM-XXXXX Build/UP1A.23XXXX.xxx; xx) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.64 Mobile Safari/537.36

ACRA UUID = 73474d9c-c662-4436-afdd-f5404f157646

Crash Reports Enabled = true

(Optional) Anything else you want to share?

No response

Research

  • [X] I am reporting a bug specific to AnkiDroid (Android app)
  • [X] I have checked the manual and the FAQ and could not find a solution to my issue
  • [ ] (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

virginviolet avatar Feb 26 '24 17:02 virginviolet

Oh... never mind. I had accidentaly(?) set the top deck to another deck category.

virginviolet avatar Feb 26 '24 17:02 virginviolet

Buut... it seems like you... sometimes? have to increase the limit on the top deck, you cannot do it on a subdeck, even if they are the same category. I feel like that's s flaw. But I don't know, this thing is confusing the heck out of me, even though I want it!

virginviolet avatar Feb 26 '24 17:02 virginviolet

How is that a flaw? If limits start from the top and the parent deck has a limit of 10 the child deck cannot possibly have a limit of 15 right?

brishtibheja avatar Apr 22 '24 05:04 brishtibheja

How is that a flaw? If limits start from the top and the parent deck has a limit of 10 the child deck cannot possibly have a limit of 15 right?

I expected parent decks to have their temporary limit also increased if you increase a child deck. Partly because that worked before I enabled "Limits start from the top", and that was very practical. Instead, it seemed like nothing happened. But I guess you're right.

For some reason, this whole thing (limits) is very unintuitive and confusing for me. But I do prefer "limits start from the top", now that I've figured out how to work with it. I don't think I would have figured it out had I not made this issue.

Might I suggest the following feature/improvement? When you increase the temporary limit of a child deck beyond the limit of its parent, the parent's limit get increased enough to fill the user's request. Perhaps with a dialogue asking the user to confirm that this is what they want. Though, I cannot imagine the user wanting anything else. This would save them from confusion (as in my case) and also save them time. I have three layers to some of my decks, and it's annoying to have to increase the temporary limit three times or more depending on how many child decks I want to study.

I guess it would also be nice if, when you increase the temporary limit of a parent deck, the app asks you if you want to replenish the child decks as well. This might not be something you always want to do, but it could be a quality of life improvement.

virginviolet avatar Apr 24 '24 21:04 virginviolet

I didn't read all of it but yeah I agree this whole limit thing has become confusing and unintuitive after V3.

But I guess you're right.

I said that but I've faced some issues with limits myself so now I'm not even sure.

Actually @virginviolet is this issue I logged somewhat related to yours? https://github.com/ankidroid/Anki-Android/issues/16243

brishtibheja avatar Apr 25 '24 16:04 brishtibheja

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Jul 24 '24 16:07 github-actions[bot]