Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Published 20 hours ago • verified publisher icon ankidroid

Timer stopped after timebox

Open soCallmeAdityaKumar opened this issue 1 year ago • 1 comments

Purpose / Description

Timer keeps running even the timebox was shown

Fixes

  • Fixes https://github.com/ankidroid/Anki-Android/issues/15500

How Has This Been Tested?

https://github.com/ankidroid/Anki-Android/assets/101629190/a9927ec8-748f-4db8-9dce-10daf9d2da2a

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [ ] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

soCallmeAdityaKumar avatar Feb 17 '24 11:02 soCallmeAdityaKumar

How does this work? I don't see the variable being set to true anywhere

ohh sorry , i just removed it while cleaning the code , just pushing it

soCallmeAdityaKumar avatar Feb 17 '24 20:02 soCallmeAdityaKumar

These two commits have identical titles, better squash them before merging.

WPum avatar Mar 21 '24 10:03 WPum

@criticalAY @BrayanDSO review required , i don't think this requires much changes and can be close easily

soCallmeAdityaKumar avatar Mar 28 '24 07:03 soCallmeAdityaKumar

@soCallmeAdityaKumar Did you check why the bug started happening? I think it should be working initially.

ShridharGoel avatar Mar 28 '24 14:03 ShridharGoel

@soCallmeAdityaKumar Did you check why the bug started happening? I think it should be working initially.

https://github.com/ankidroid/Anki-Android/assets/101629190/ac582561-2f0a-482f-8544-92b2d82a6dee

  1. Open setting ->Reviewing->Set TimeBox Limit to 1
  2. Open any deck to review-> Open Deck Options and set maximum answer seconds to 30 seconds

Now review the cards , don't click show answer for more thant 60 seconds , and then click show answer , click your answer (Easy , hard...) then the timebox will popup and we will see that the timer continue even if the we have't chosen options from time box popup.

soCallmeAdityaKumar avatar Mar 29 '24 07:03 soCallmeAdityaKumar

opened an new pull request https://github.com/ankidroid/Anki-Android/pull/16871

soCallmeAdityaKumar avatar Aug 15 '24 13:08 soCallmeAdityaKumar