Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Unified undo/redo queue

Open user1823 opened this issue 2 years ago • 5 comments

The Redo option added in alpha 6 only works for undo actions performed from the Reviewer; it doesn't work if an answer was undone from the Decks page or the Browser.

This means that there are separate undo/redo queues for the Reviewer and Browser. I think that it will be better if the same queue is used for both so that actions performed anywhere in the app can be reversed from everywhere.

user1823 avatar Nov 22 '23 11:11 user1823

@dae I think this may be related to previous backend-related undo/redo work. I'm a little out of touch here though - thus the tag and question - I think the base thought here is correct and we may have a backend undo/redo queue and an AnkiDroid-level undo/redo queue at the moment? 😬

mikehardy avatar Nov 22 '23 14:11 mikehardy

This was broken by https://github.com/ankidroid/Anki-Android/issues/14538, as performing any collection modification clears the redo queue. @lukstbit, I suggest switching to the backend's customStudyDefaults(), and using .available*. You can then remove the manual SQL in StudyOptionsFragment, and probably totalRev/NewForCurrentDeck() and updateValuesFromDeck() as well.

dae avatar Nov 24 '23 03:11 dae

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Feb 22 '24 05:02 github-actions[bot]

Still looking for a solution...

user1823 avatar Feb 22 '24 06:02 user1823

@user1823 if you have time, could you come to Discord, or send me an email regarding your priorities for 2.18? Would be great to know where your priorities lie

Discord: https://discord.gg/qjzcRTx Email: davidallisongithub (gmail)

david-allison avatar Feb 22 '24 06:02 david-allison