Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Add fastlane metadata for F-Droid

Open shuvashish76 opened this issue 1 year ago • 8 comments

Pull Request template

Screenshots & metadata for F-Droid

Purpose / Description

Describe the problem or feature and motivation Dhow nicer screenshots to F-Droid users which can be changed by AnkiDroid maintainers later without notifying F-Droid maintainers every time we need a change.

Fixes

Fixes #7999

Approach

How does this change address the problem? Basic but effective.

How Has This Been Tested?

Screenshots copied from https://github.com/ankidroid/Anki-Android/tree/main/docs/marketing. Description from both F-Droid & PlayStore

Learning (optional, can help others)

Describe the research stage NA Links to blog posts, patterns, libraries or addons used to solve this problem NA

Checklist

Please, go through these checks before submitting the PR.

  • [ ] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [ ] You have commented your code, particularly in hard-to-understand areas
  • [ ] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

shuvashish76 avatar Jul 30 '23 12:07 shuvashish76

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

welcome[bot] avatar Jul 30 '23 12:07 welcome[bot]

what is the blocker here?

licaon-kter avatar Mar 20 '24 15:03 licaon-kter

Not sure about icon.png as it does not match the one at Google Play and the README and stuff. I feel like it should probably be https://github.com/ankidroid/Anki-Android/blob/main/docs/graphics/logos/ankidroid_logo.png Not sure about featureGraphic.png for the same reason, though don't know what to suggest instead.

Otherwise it LGTM and I am very much in favor of merging, as no icon and no screenshots look a little sad :(

leoheitmannruiz avatar May 24 '24 21:05 leoheitmannruiz

Then replace them as needed

licaon-kter avatar May 25 '24 06:05 licaon-kter

I don't quite understand.

I'm just some person passing by (should've probably made that more clear). Is there anything I can do, apart from opening a new PR? What do you suggest I do?

Or did you, reasonably, assume I was more than a stranger to AnkiDroid?

leoheitmannruiz avatar May 25 '24 10:05 leoheitmannruiz

I'm just some person passing by

Aren't we all... :)

licaon-kter avatar May 25 '24 11:05 licaon-kter

When was making an edit in https://alternativeto.net/software/ankidroid/about/, used these sources

  • Icon: https://github.com/ankidroid/Anki-Android/blob/main/docs/graphics/legacy/anki.svg
  • Screenshots: https://github.com/ankidroid/Anki-Android/tree/main/docs/marketing/play_store and https://github.com/ankidroid/Anki-Android/tree/main/docs/marketing/screenshots/en-US/phone

Don't quite like the proposed banner, https://github.com/ankidroid/Anki-Android/blob/main/docs/graphics/logos/banner_readme.png would look better

NamelessGO avatar May 25 '24 18:05 NamelessGO

@shuvashish76 can you please have a look at my comments? Perhaps this PR can then be merged soon :)

leoheitmannruiz avatar Jun 17 '24 11:06 leoheitmannruiz

A link to https://gitlab.com/-/snippets/1895688 so that it's clear where the file structure is. (Don't hesitate to provide a better link

https://f-droid.org/docs/All_About_Descriptions_Graphics_and_Screenshots/

shuvashish76 avatar Jul 14 '24 04:07 shuvashish76

@Arthur-Milchior this is a very minor PR about F-Droid metadata but pending for ~1year. I understand there are other important PRs to look after. Request to change whatever changes necessary from your side & merge as soon as possible, thanks.

shuvashish76 avatar Aug 15 '24 23:08 shuvashish76

We requested changes. Finally, I did them myself. I'll fetch for another reviewer, thanks for the ping

Arthur-Milchior avatar Aug 16 '24 11:08 Arthur-Milchior

Thank you very much @shuvashish76 for pinging us again and again, Very sorry it took so much time

Arthur-Milchior avatar Aug 18 '24 12:08 Arthur-Milchior