Help: Back on dialog

[criticalAY]

Shouldn't be be getting back to the main screen if we press somewhere else other than the dialog. Like as of now we get to the previous dialogue if we click outside the dialog box. https://user-images.githubusercontent.com/48384865/193473133-bf5aecaa-f15d-4680-9593-dedc4f940925.mp4

[lukstbit]

Shouldn't be be getting back to the main screen if we press somewhere else other than the dialog

Normally yes, but there we have a hierarchy of dialogs and I think it makes sense to go back the the previous dialog even on tap outside. Ideally this part should be refactored to avoid the double dialog situation but there are more important things to tackle right now.

[criticalAY]

We can mark it as Good for first ?

[mikehardy]

I disagree on a tap outside only going back, as an android user, if I tap outside a dialog I expect it to dismiss the dialog in almost all cases, and I don't see why the dialogs here would be an exception? I think this is a valid issue

[oyeraghib]

I would like to work on this, if no one has started yet.

[lukstbit]

@oyeraghib I think @criticalAY intended to work on this as he opened the issue, so lets wait a bit.

[oyeraghib]

sure!

[criticalAY]

Yes! I am on it but if I am running out of time or something I will let you know and you can overtake it @oyeraghib cool?

[oyeraghib]

Sure, there is no rush. Take your time :)

[oakkitten]

Istead of trying to fix it, I would suggest replacing the recursive help dialog with a single bottom sheet dialog with a directory tree structure. This doesn't have too many items, so it will make things easier to find, and we (may soon) have the infrastructure to do this with minimal code.

Alternatively, put all the help of information in a HTML page and display that.

[criticalAY]

Istead of trying to fix it, I would suggest replacing the recursive help dialog with a single bottom sheet dialog with a directory tree structure. This doesn't have too many items, so it will make things easier to find, and we (may soon) have the infrastructure to do this with minimal code.

Alternatively, put all the help of information in a HTML page and display that.

Okay let's see

[SySagar]

hello @criticalAY if you are not working on this , I will like to take it up.

[criticalAY]

hello @criticalAY if you are not working on this , I will like to take it up.

Ahh I am on it.

[raehat]

@criticalAY hey are you still working on it?

[criticalAY]

I am not pushing any PRs for this rn because it needs time and there are other important things to handle right now as everyone is busy. We plan to replace the dialog fragment with bottom sheet dialog here

[Sagar0-0]

am not pushing any PRs for this rn because it needs time and there are other important things to handle right now as everyone is busy. We plan to replace the dialog fragment with bottom sheet dialog here

Should I do it?

[criticalAY]

am not pushing any PRs for this rn because it needs time and there are other important things to handle right now as everyone is busy. We plan to replace the dialog fragment with bottom sheet dialog here

Should I do it?

Ummm it's not that easy as it seems as I would not say it's a good first issue now, more like new feature implementation. Bottom sheet with tree structure. But if you wanna try it then sure give it a try. But if you are taking it because of good first issue I wouldn't suggest this one in that case.

[mikehardy]

agreed I think this was a bit more complicated then it first appeared, removed good first issue tag for now, better to get a truly simple PR done as a first PR, to learn all the other stuff related to getting PRs merged on this project while the actual code change isn't so difficult

[github-actions[bot]]

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

[criticalAY]

@mikehardy could you please mark it 'keep open' as it is a new feature that would be implemented afterward most probably after scoped storage migration.

[criticalAY]

The bottom sheet can be an improvement but as of now @lukstbit already have fixed the issue

[david-allison]

@criticalAY can this be closed? If not, what changes are still needed?

[criticalAY]

Yes we can I was talking about the bottom sheet but that's not coming anytime soon so closing it