Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

NF: converting Long to DeckId

Open Arthur-Milchior opened this issue 1 year ago • 1 comments

Those one were found with searcing for "eckId: Long"

Arthur-Milchior avatar Aug 07 '22 15:08 Arthur-Milchior

Me either - lowercase type names don't seem to be idiomatic in Kotlin, and "did: DeckId" would make it much more readable for people not familiar with Anki's abbreviations.

dae avatar Aug 10 '22 22:08 dae

Modified. In this case, I note that Python originally use did but it's renamed for consistency with Kotlin style. I love having proper type. I don't like having two types with no semantic difference

Arthur-Milchior avatar Aug 12 '22 20:08 Arthur-Milchior

Comment corrected. Thanks. No idea why I thought did was a Python type. I should have spent enough time there to recall how it worked.

Arthur-Milchior avatar Aug 13 '22 13:08 Arthur-Milchior