Enlarge size of checkbox in Tag Picker dialog

[oyeraghib]

Purpose / Description

Enlarge size of checkbox in Tag Picker dialog as mentioned in #11139 because

The clickable region that toggles the checkbox is now shrunk to the checkbox itself only (not true for leaf tags), which endangers misclick.

Fixes

fixes #11139

Approach

As mentioned in the #11139 , it was decided to make the size to 48x48dp. I tried implementing that to (48x48) and found it a bit odd (can be termed as subjective - also maybe because other icons on screen are not that big) so I tried implementing it to 36x36 which looks better and also fixes the issue of misclick happening. Though it is subjective to make it 48x48 or 36x36 but I am open to any changes further required upon discussion in the comments.

For reference here is the link to images :

24x24 (current)

36x36

48x48

How Has This Been Tested?

Manually on physical device

Checklist

• [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
• [x] You have a descriptive commit message with a short title (first line, max 50 chars).
• [x] Your code follows the style of the project (e.g. never omit braces in if statements)
• [x] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

[oyeraghib]

@david-allison I checked with Accessibility scanner and it says Consider making this clickable items larger but for 48x48 it works good. Should I make it 48x48 then ? Also for the three options at bottom of Dialog box All cards, New and Due accessibility scanner says Consider making this clickable items larger

[BrayanDSO]

Is it possible to increase the checkbox clickable area while not increasing the checkbox itself?

[oyeraghib]

@BrayanDSO yes it's possible to do that. Keeping the checkbox size to 24x24 we can make the clickable region 48x48

[BrayanDSO]

@BrayanDSO yes it's possible to do that. Keeping the checkbox size to 24x24 we can make the clickable region 48x48

I'm particularly fine with it and like it more than making the checkboxes 48x48. Up to the actual reviewers' and yourself as the implementator to decide, though

[mikehardy]

I like 24x24 visual with 48x48 touchable area personally (I've heard this referred to as "hit slop" before, I wonder if that's a standard term?)