Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Replaced Add note icon with new Add note icon

Open prathamsoni11 opened this issue 2 years ago • 3 comments

Purpose / Description

Added new icon for Add note as mentioned in issue #10773 .

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • [ ] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] Your code follows the style of the project (e.g. never omit braces in if statements)
  • [ ] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing
  • [x] UI Changes: You have tested your change using the Google Accessibility Scanner

Screenshot_2022-07-25-14-53-04-913_com ichi2 anki any new or changed strings)

prathamsoni11 avatar Jul 25 '22 09:07 prathamsoni11

@prathamsoni11 Thanks for contributing. Please fill out the complete PR Template

prateek-singh-3212 avatar Jul 25 '22 18:07 prateek-singh-3212

Duplicate of #11915

p.s: didn't know I had permission to tag duplicates automatically and as I'm supposed to use my rights only to tag my PRs, I've untagged it

BrayanDSO avatar Jul 25 '22 21:07 BrayanDSO

Thanks for pointing it out.

prateek-singh-3212 avatar Jul 25 '22 21:07 prateek-singh-3212

I apologize this has sat as long as it has, and I really appreciate the attempt to make a change here in AnkiDroid - unfortunately we (maintainers) let the issue of whether to change the icon or not sit on the original issue without really being clear.

Thinking about it now, I must admit I also prefer the current icon that is the same general card shape as the deck one, so I'm going to close this with apologies

mikehardy avatar Aug 19 '22 01:08 mikehardy