Update ic_add_note.xml (new add sign)

[samarthasthan]

Update ic_add_note.xml (new add sign)

Description

The shape of the current Add note icon doesn't look like a note, but a card. So I changed it and got a good one

Fixes

Issue no #10773 Fixes Link to the issues.

Approach

By deleting old ic_add_note.xml to new good looking ic_add_note.xml

How Has This Been Tested?

I have use Genymotion Emulator to test this change Tested on SDK 29, 30, 31 and 32.

Checklist

• [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
• [x] You have a descriptive commit message with a short title (first line, max 50 chars).
• [x] Your code follows the style of the project (e.g. never omit braces in if statements)
• [x] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [x] UI Changes: You have tested your change using the Google Accessibility Scanner

[welcome[bot]]

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

[Arthur-Milchior]

To avoid clicking to the original issue, here is the screenshot :

I tested locally, it works. I don't mind one way or another, both icons are fine by me. I'll let any reviewer with an opinion decide

[BrayanDSO]

The issue was fixed by #11876. Probably there was a misunderstanding here.

Initially the issue's author wanted to change the icon, but later in the discussion they changed their opinion and the issue was changed from Replace the string, "Add note", of Decks-screen's-add-button-menu item with "Add card" to Replace the string, "Add note", of Decks-screen's-add-button-menu item with "Add", which was fixed by #11876.

About the icon change itself, I've already stated my opinion on the original issue as well (against it).

[mikehardy]

I apologize this has sat as long as it has, and I really appreciate the attempt to make a change here in AnkiDroid - unfortunately we (maintainers) let the issue of whether to change the icon or not sit on the original issue without really being clear.

Thinking about it now, I must admit I also prefer the current icon that is the same general card shape as the deck one, so I'm going to close this with apologies