Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

WindowInsets

Open n1snt opened this issue 3 years ago • 2 comments

Purpose / Description

Deprecated UI flags were replaced by WindowInsets.

Fixes

Fixes #9332

How Has This Been Tested?

Ran tests & tested on:

  • Physical Device (Android 12)
  • Virtual Device (Android 7)

Learning (optional, can help others)

I read this guide & went through this pull request.

Checklist

  • [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] Your code follows the style of the project (e.g. never omit braces in if statements)
  • [x] You have commented on your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [x] UI Changes: You have tested your change using the Google Accessibility Scanner

n1snt avatar Jun 04 '22 21:06 n1snt

I'm a bit busy at the moment. Will get back to this as soon as I get some free time :)

n1snt avatar Jun 26 '22 17:06 n1snt

I know the feeling! no rush

david-allison avatar Jun 27 '22 15:06 david-allison

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Dec 03 '22 14:12 github-actions[bot]

I forgot about this issue. Will fix the merge conflicts & start working on it again once I'm done with my exams.

n1snt avatar Dec 08 '22 05:12 n1snt

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Feb 06 '23 06:02 github-actions[bot]