Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard
verified publisher icon ankidroid

[JS Addons] Addon storage class for handling addons related file/folder functions

Open krmanik opened this issue 3 years ago • 5 comments

Pull Request template

Purpose / Description

Handle addons related file/folder functions in a centralized class AddonStorage.

Fixes

Fixes

Approach

  1. Create new class AddonStorage and implement possibly used methods
  2. Move methods for addons related file/folder to AddonStorage

How Has This Been Tested?

Implemented unit test

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] Your code follows the style of the project (e.g. never omit braces in if statements)
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

krmanik avatar Apr 25 '22 13:04 krmanik

@david-allison I think this one is on you for a re-look?

mikehardy avatar May 10 '22 16:05 mikehardy

I will update the PR later.

krmanik avatar May 11 '22 04:05 krmanik

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Aug 01 '22 11:08 github-actions[bot]

Pinning this open - it will happen...

mikehardy avatar Aug 01 '22 23:08 mikehardy

The addons feature is in progress. I have created a discussion on https://forums.ankiweb.net for better cross platform addons support. https://forums.ankiweb.net/t/ideas-features-cross-platform-js-addons-support-using-rust-backend-and-svelte-frontend/21172?u=krmanik

Also to learn/understand more about backend and addons support, I started creating feature for Anki which will be available to Anki Ecosystem. https://github.com/krmanik/anki/pull/1

krmanik avatar Aug 02 '22 11:08 krmanik