jellyfin-youtube-metadata-plugin icon indicating copy to clipboard operation
jellyfin-youtube-metadata-plugin copied to clipboard

Fix local metadata exiting if file already exists

Open Bryan792 opened this issue 2 years ago • 1 comments

Is this logic correct? Sorry, I am not too involved with the project, so unsure.

Here's the git blame: https://github.com/ankenyr/jellyfin-youtube-metadata-plugin/commit/93f4b2784bca74133f7b9ad08c358ba4f608cff0

Bryan792 avatar Aug 15 '22 17:08 Bryan792

While trying to fix the issue myself I found a few more things that should be done.

  1. The ReadYTDLInfo Is redundant in the AbstractYoutubeRemoteProvider.cs to the Method in the Utils class
  2. ReadYTDLInfo should use the method in the Utils class as well
  3. Same with the Call in the YTDLSeriesProvider here
  4. The File.Exists you changed should then be moved to the Utils.ReadYTDLInfo for a more centralized usage.

This would then cover everything when the ReadYTDLInfo is used, not only for Movies, Series but also for Image requests (where it also fails)

Fribb avatar Aug 31 '22 14:08 Fribb

Would be great if we can merge this and get a new release out.

jacksgt avatar Apr 23 '24 21:04 jacksgt

Hey @ankenyr, this fixes a bug introduced in 93f4b2784bca74133f7b9ad08c358ba4f608cff0 that prevents getting metadata from info.json files. Could you merge it please?

Thank you.

nalsai avatar May 21 '24 04:05 nalsai