jellyfin-youtube-metadata-plugin icon indicating copy to clipboard operation
jellyfin-youtube-metadata-plugin copied to clipboard

Fix Dockerfile in README.md

Open Jurrer opened this issue 1 year ago • 1 comments

Bro, pls fix it because it's not building properly. I have spent too much time troubleshooting this.

Jurrer avatar Sep 23 '24 23:09 Jurrer

Hey @Jurrer do you know what the change you made actually does?

ankenyr avatar Sep 24 '24 00:09 ankenyr

I believe this is about the implementation of PEP 668 on Debian. You cannot install via pip on the system install, i.e. out of a venv. Usually, people switch from pip to pipx (it manages the venv for the installed pip application). Probably since Jellyfin switched to a Debian bookworm based image python3 >= 3.11.1-3 which declares the installation to be EXTERNALLY-MANAGED. https://peps.python.org/pep-0668/

The correct fix is not to add --break-system-packages but to switch to pipx, even though for a container system this is less critical so --break-system-packages can only mangle the container it is building for itself.

 error: externally-managed-environment

× This environment is externally managed

╰─> To install Python packages system-wide, try apt install

python3-xyz, where xyz is the package you are trying to

install.

If you wish to install a non-Debian-packaged Python package,

create a virtual environment using python3 -m venv path/to/venv.

Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make

sure you have python3-full installed.

If you wish to install a non-Debian packaged Python application,

it may be easiest to use pipx install xyz, which will manage a

virtual environment for you. Make sure you have pipx installed.

See /usr/share/doc/python3.11/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.

hint: See PEP 668 for the detailed specification. 

prahal avatar Jan 26 '25 14:01 prahal

That is exactly what it does. I will be closing this PR

ankenyr avatar Jan 26 '25 19:01 ankenyr

@Jurrer would you be willing to redo this PR with pipx instead of --break-system-packages?

prahal avatar Apr 06 '25 23:04 prahal

Hi @prahal I have stopped using this plugin in favor of TubeArchivist. Feel free to open an issue about it so it does not get forgotten :)

Jurrer avatar Apr 06 '25 23:04 Jurrer