Andrew Kane

Results 377 comments of Andrew Kane

Hey @lettergram, thanks for wanting to help with this. Right now, support for bubble charts in Chartkick.js is experimental, so don't think it makes sense to add it to Chartkick.

@lettergram thanks for offering. At the moment, I'm hesitant to add new chart types. The most common types are already covered and it increases maintenance.

Hey @georgeu2000, I'm not sure there's a way to do this now, but happy to discuss how to make this possible.

@georgeu2000 We could add a new format to allow for options to be passed in AJAX requests, like: ``` ruby render json: {data: data, min: 0, library: {...}} ```

Hey @dimerman, can you use [this gist](https://gist.github.com/ankane/35332faacd7ed70d8e51ea5bbb17dfb8) to reproduce?

Thanks. However, it looks like it is returning an empty hash on line 36.

Hey @raypereda, great idea! Added support on the `decimal` branch. I'd like to do a bit more testing before merging.

My main concern right now is [data leakage](https://github.com/ankane/lockbox#data-leakage). Decimal is a variable-length type, which isn't ideal for encryption. With the implementation in the `decimal` branch, if you store money in...

Hey @pjmartorell, nice find and debugging. A fix should be straightforward, but my worry is it'll break apps that rely on the current behavior (likely without realizing it). I think...

Hey @danleyden, agree it should be easier to rotate the master key. Let me think on the best way to do that. For now, you could add a method to...