blazer icon indicating copy to clipboard operation
blazer copied to clipboard

Published 20 hours ago • verified publisher icon ankane

Added name validation to query & dashboard

Open pandu-49-zz opened this issue 4 years ago • 2 comments

Added presence and uniqueness validation to queries and dashboards. Uniqueness validation score creator_id so that a user can have unique name which makes easy to identify and it avoids confusion.

pandu-49-zz avatar Jul 29 '20 14:07 pandu-49-zz

Hey @pandu-49, thanks for another PR! I like the idea. It should probably only run the uniqueness validation when the name changes, so existing queries and dashboards that have duplicate names won't be affected. Also, an empty string in the name of query indicates a private query, so it'll need to support that. Let's keep the validations inline for each of the models, even if there's a small bit of duplication.

ankane avatar Oct 07 '20 07:10 ankane

@ankane Thanks for the response. Could you explain me more about private queries? Any example!

Are these are storing into database from any other place?

pandu-49-zz avatar Dec 29 '20 06:12 pandu-49-zz