paranoid2 icon indicating copy to clipboard operation
paranoid2 copied to clipboard

Published 20 hours ago • verified publisher icon anjlab

Naming issues

Open jgwmaxwell opened this issue 10 years ago • 0 comments

Hi there,

I was auditing this for use in a project, but there's an issue with calling the field deleted_at and using #with_deleted as a name. Destroy in Rails will fire all callbacks, but Delete will not, and mixing up the concepts in your naming causes confusion about what this actually does.

Happy to submit a PR to fix if you agree?

Cheers,

John

jgwmaxwell avatar Oct 21 '14 13:10 jgwmaxwell