powerup-iOS icon indicating copy to clipboard operation
powerup-iOS copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

Error in conversation with Macello in Home

Open anubhavpulkit opened this issue 5 years ago • 11 comments

Description

The user completes the Home scenario, then the outro sequence occurs. When the outro completes, the Home scenario screen shows briefly and then the Mine Sweeper games appear. This brief appearance of the Home scenario screen should not occur at all.

Mocks

powerup.mov.zip

Acceptance Criteria

Update [Required]

  • [x] [Remove the conversation screen which comes just before Mine Sweeper Game] or
  • [x] [Increase the time suspended time of conversation screen with relevant conversation]

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

[4] hours

anubhavpulkit avatar Feb 21 '20 22:02 anubhavpulkit

@sunjunkie please have a look. Can I work on this issue?

anubhavpulkit avatar Feb 21 '20 22:02 anubhavpulkit

Yes. But let's add more detail to the issue description. The user completes the Home scenario, then the outro sequence occurs. When the outro completes, the Home scenario screen shows briefly and then the Mine Sweeper games appears. This brief appearance if the Home scenario screen should not occur at all.

sunjunkie avatar Feb 24 '20 20:02 sunjunkie

@sunjunkie is it right now?

anubhavpulkit avatar Feb 24 '20 21:02 anubhavpulkit

Remove the 1st paragraph.

sunjunkie avatar Feb 25 '20 06:02 sunjunkie

Thank you @sunjunkie

anubhavpulkit avatar Feb 25 '20 07:02 anubhavpulkit

@sunjunkie I need help on this issue?

anubhavpulkit avatar Feb 29 '20 21:02 anubhavpulkit

Please explain your problem.

sunjunkie avatar Feb 29 '20 22:02 sunjunkie

Sorry, @sunjunkie I saw your reply but I want to try more times so I can't give reply to this issue but after some more efforts, I can't understand the relation sequence between popup Event and Story sequence.

anubhavpulkit avatar Mar 03 '20 17:03 anubhavpulkit

These links provide some background- Terminology: https://github.com/anitab-org/powerup-iOS/wiki/Terminology-for-OOC-event-classes-and-utility-web-apps Story Designer readme: https://github.com/anitab-org/powerup-story-designer Cady's notes from GSoC 2018: https://github.com/anitab-org/powerup-iOS/wiki/GSoC-2018-Cadence-Holmes

sunjunkie avatar Mar 03 '20 21:03 sunjunkie

Ok, thank you @sunjunkie I read first one last day. I hope I get some help from 2 or 3 links.

anubhavpulkit avatar Mar 03 '20 21:03 anubhavpulkit

Hi there. So just to be clear the PopupEvents and StorySequences are unrelated. They are separate things entirely. PopupEvents are essentially just notification popups and can be triggered anywhere. StorySequences are the semi-automated dialogue sequences that can occur before and after a scene.

StorySequences aren't pushed with their own view controller. They are just container in a UIView overlaying the current view controller. So, when it's finished, it is disposed of by the scene VC before the minigame VC takes over. The StorySequence class handles removing and disposing of it's own view when the sequence is finished. Resolving this issue might be as simple as not letting it do that...

justkd avatar Mar 09 '20 21:03 justkd