powerup-android icon indicating copy to clipboard operation
powerup-android copied to clipboard

Remove android:configChanges="orientation|keyboardHidden" in AndroidManifest.xml

Open PrajwalM2212 opened this issue 7 years ago • 7 comments

Description

The Android Manifest file contains android:configChanges="orientation|keyboardHidden" in nearly all the activities in the project . It is not required and just a performance barrier . The app already has onSaveInstanceState() and onRestoreInstanceState() implemented wherever necessary and hence does not require android:configChanges="orientation|keyboardHidden".

Mocks

[INSERT RELEVANT PNG FILE] manifest 1 manifest 2 manifest 3

Acceptance Criteria

Update [Required]

  • [ ] AndroidManifest.xml

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

10 minutes

PrajwalM2212 avatar Feb 11 '18 03:02 PrajwalM2212

@codingblazer @anubhakushwaha @MeepyMay I would like to work on this issue .

PrajwalM2212 avatar Feb 11 '18 03:02 PrajwalM2212

#985 will handle this issue . Also, please don't create pull request until any mentor approves it :)

geekanamika avatar Feb 12 '18 14:02 geekanamika

@geekanamika This issue handles android:configChanges="orientation|keyboardHidden" and does not overlap with your issue of dealing with android:screenOrientation="landscape" . 😊 There are some pull requests sent without approval from mentors prompting me to send one myself.

PrajwalM2212 avatar Feb 12 '18 18:02 PrajwalM2212

Is this a valid issue? Pls tell so that we can review the associated PR too. @m-murad @geekanamika @Rimjhim28

contactvaibhavi avatar Apr 23 '18 15:04 contactvaibhavi

@Rimjhim28 @geekanamika can I work on this ?

vibhusharma101 avatar Feb 23 '20 14:02 vibhusharma101

@Rimjhim28 @geekanamika Can i work on this issue?

Priyansh-Kedia avatar Feb 26 '20 15:02 Priyansh-Kedia

May I work on this issue?

Mehulipal avatar Mar 08 '20 10:03 Mehulipal