powerup-android
powerup-android copied to clipboard
Remove android:configChanges="orientation|keyboardHidden" in AndroidManifest.xml
Description
The Android Manifest file contains android:configChanges="orientation|keyboardHidden"
in nearly all the activities in the project . It is not required and just a performance barrier . The app already has onSaveInstanceState()
and onRestoreInstanceState()
implemented wherever necessary and hence does not require android:configChanges="orientation|keyboardHidden"
.
Mocks
[INSERT RELEVANT PNG FILE]
Acceptance Criteria
Update [Required]
- [ ] AndroidManifest.xml
Definition of Done
- [ ] All of the required items are completed.
- [ ] Approval by 1 mentor.
Estimation
10 minutes
@codingblazer @anubhakushwaha @MeepyMay I would like to work on this issue .
#985 will handle this issue . Also, please don't create pull request until any mentor approves it :)
@geekanamika This issue handles android:configChanges="orientation|keyboardHidden" and does not overlap with your issue of dealing with android:screenOrientation="landscape" . 😊 There are some pull requests sent without approval from mentors prompting me to send one myself.
Is this a valid issue? Pls tell so that we can review the associated PR too. @m-murad @geekanamika @Rimjhim28
@Rimjhim28 @geekanamika can I work on this ?
@Rimjhim28 @geekanamika Can i work on this issue?
May I work on this issue?