powerup-android icon indicating copy to clipboard operation
powerup-android copied to clipboard

Fixes issue #1132. Implemented ConstraintLayout

Open devanshi7799 opened this issue 5 years ago • 7 comments

Description

Implemented ConstraintLayout in gamemap.xml file. Changed FrameLayout to ConstraintLayout Fixes #1132

Type of Change:

Delete irrelevant options.

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested it on my android phone

Checklist:

Delete irrelevant options.

  • [ ] My PR follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code or materials
  • [ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] Any dependent changes have been merged

Code/Quality Assurance Only

  • [ ] My changes generate no new warnings
  • [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been published in downstream modules

devanshi7799 avatar Feb 26 '20 14:02 devanshi7799

Please review this and tell me what more changes are to be made

devanshi7799 avatar Feb 26 '20 14:02 devanshi7799

@devanshi7799 how is this solving the nesting issue? I think you need to flatten the Layout hierarchy. And it needs to be done for 3 XML files, I can see changes made only to one

sammy1997 avatar Apr 12 '20 19:04 sammy1997

@sammy1997 sir can i work on this issue?

therealsanjeev avatar Apr 12 '20 20:04 therealsanjeev

@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently

sammy1997 avatar Apr 13 '20 12:04 sammy1997

@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently

ok sir

therealsanjeev avatar Apr 13 '20 12:04 therealsanjeev

@sammy1997 working on it. Will update my PR soon :))

devanshi7799 avatar Apr 14 '20 23:04 devanshi7799

@devanshi7799 there are 9 commits and many of them are not passing the build. Please squash the commits into 1

sammy1997 avatar Apr 18 '20 08:04 sammy1997