powerup-android icon indicating copy to clipboard operation
powerup-android copied to clipboard

Karma point adds abruptly with multiple taps.

Open hridyakrishna opened this issue 6 years ago • 7 comments

Description

The Karma points gets added when tapped more than a certain number of times in scene:home,school and hospital.

Mocks

ezgif com-video-to-gif

Acceptance Criteria

Update [Required]

The karma points scored by corrrect answers should be same even if tappped multiple times.

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

48 hours

hridyakrishna avatar Jan 26 '19 10:01 hridyakrishna

May I work on this issue?

hridyakrishna avatar Jan 26 '19 10:01 hridyakrishna

@hsymphonyk The issue looks valid. Can you please find and comment here the reason behind the issue and how you want to fix this?

Rimjhim28 avatar Jan 28 '19 12:01 Rimjhim28

This issue can be resolved by making certain changes in the GameActivity.java file. SessionHistory.currScenePoints behaves normally when game is played slowly, but the score changes when the gameplay speed is increased. I hope this can be resolved by giving a seperate thread for adding points rather than being on the same thread as of UI. What do you suggest about this @Rimjhim28

hridyakrishna avatar Feb 20 '19 15:02 hridyakrishna

@hsymphonyk @Rimjhim28 Can't we shift currScenePoints to preferences & update value off the main thread? Do we really need SessionHistory & static variables? Correct me If I'm wrong.

geekanamika avatar Feb 24 '19 05:02 geekanamika

Hello,@geekanamika That is a good idea. Did you try implementing it?

hridyakrishna avatar Feb 24 '19 08:02 hridyakrishna

This sounds logical @geekanamika @hsymphonyk Can you work towards the solution the way suggested by @geekanamika

Rimjhim28 avatar Feb 24 '19 19:02 Rimjhim28

Hello @Rimjhim28, I will surely work the way suggested by @geekanamika.Thank you

hridyakrishna avatar Feb 26 '19 12:02 hridyakrishna